[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

Daniel Jasper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 1 06:31:26 PST 2018


djasper added a comment.

I don't mean trivial with a diff. What I mean is, users will find it surprising if whether or not a parameter gets wrapped leads to a different indentation internal to that parameter. I have not heard of a single user that would be surprised by this extra indentation.

I don't think this is worth an extra setting. I'll be somewhat resistant to getting this in because a) I think it's wrong and b) never change a running system (users will have at least gotten used to it). But I also don't want to assume total power here, I do not care that much about this issue. I'll add some other clang-format authors as reviewers here and you can also feel free to add more people. If the common opinion is that your change is good, I am happy to move forward.


Repository:
  rC Clang

https://reviews.llvm.org/D42787





More information about the cfe-commits mailing list