[PATCH] D42517: [clangd] Pass Context implicitly using TLS.

[Sam McCall via Phabricator via cfe-commits]

sammccall marked 2 inline comments as done.
sammccall added inline comments.


================
Comment at: clangd/Context.h:196
+  ~WithContext() {
+    if (Restore)
+      Context::swap(std::move(*Restore));
----------------
ilya-biryukov wrote:
> I think it can't be `null` after move ctor is deleted.
> Maybe always store a `Context` instead of `unique_ptr` and call `swap` unconditionally?
Right! much nicer.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42517