[PATCH] D42174: [clangd] Refactored threading in ClangdServer

[Sam McCall via Phabricator via cfe-commits]

sammccall added a comment.

Can you please remove the `threading/` subdirectory?
It seems premature for these two files, and `TUScheduler` doesn't fit. It's unclear that there will be more.

I'd suggest renaming `Threadpool.h` -> `Threading.h`, CancellationFlag might fit in there, though up to you.



================
Comment at: clangd/threading/TUScheduler.h:1
+//===--- TUScheduler.h -------------------------------------------*-C++-*-===//
+//
----------------
this class needs tests


================
Comment at: clangd/threading/ThreadPool.h:1
+//===--- ThreadPool.h --------------------------------------------*- C++-*-===//
+//
----------------
this class needs tests


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42174