[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 29 07:05:33 PST 2018


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.

Can you also remove the URI-encoding hack from the VSCode client?



================
Comment at: clangd/Protocol.cpp:35
+    }
+    auto Resolved = URI::resolve(*U);
+    if (!Resolved) {
----------------
I think you can just check that the scheme is file and pull out the path?
we don't want to expose custom URI schemes in LSP, I think


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42419





More information about the cfe-commits mailing list