[PATCH] D42395: [clang-format] Fix bug where -dump-config failed on ObjC header

Ben Hamilton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 26 13:26:13 PST 2018


benhamilton requested review of this revision.
benhamilton marked 2 inline comments as done.
benhamilton added inline comments.


================
Comment at: test/Format/lit.local.cfg:1
+# Suffixes supported by clang-format.
+config.suffixes = ['.c', '.cc', '.cpp', '.h', '.m', '.mm', '.java', '.js',
----------------
krasimir wrote:
> Why is this needed?
'.h' is not in the list of file suffixes which lit is configured to look for:

https://github.com/llvm-mirror/clang/blob/master/test/lit.cfg.py#L28

So, we need to provide our own list of file suffixes here.

Other tests do the same:

https://github.com/llvm-mirror/clang/search?utf8=%E2%9C%93&q=%22config.suffixes%22&type=

so I think it's OK to do so here as well.


Repository:
  rC Clang

https://reviews.llvm.org/D42395





More information about the cfe-commits mailing list