[PATCH] D42560: [analyzer] dump() ExprEngine's internal traits into the ExplodedGraph view.

[George Karpenkov via Phabricator via cfe-commits]

george.karpenkov added a comment.

Looks good



================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:392
+
+    auto InitTempSet = State->get<InitializedTemporariesSet>();
+    if (!InitTempSet.isEmpty()) {
----------------
Actually I would put both of those into static functions: printInitializedTemporaries, printCXXNewAllocatorValues


================
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:415
+            for (auto I : NewAllocValsMap) {
+              if (I.first.second != LC)
+                continue;
----------------
Can we get a variable for `I.first`?


Repository:
  rC Clang

https://reviews.llvm.org/D42560