[PATCH] D42555: [libunwind] Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 25 13:05:51 PST 2018


mstorsjo created this revision.
mstorsjo added reviewers: compnerd, smeenai, phosek.
Herald added subscribers: kristof.beyls, aemerson.

Otherwise, a shared library build with SJLJ APIs enabled would end up with duplicate symbols.

This didn't occur for the apple && arm case due to specifically checking for that in the surrounding ifdef.


https://reviews.llvm.org/D42555

Files:
  src/config.h


Index: src/config.h
===================================================================
--- src/config.h
+++ src/config.h
@@ -72,8 +72,10 @@
     (!defined(__APPLE__) && defined(__arm__)) ||                               \
     (defined(__arm64__) || defined(__aarch64__)) ||                            \
     defined(__mips__)
+#if !defined(_LIBUNWIND_BUILD_SJLJ_APIS)
 #define _LIBUNWIND_BUILD_ZERO_COST_APIS
 #endif
+#endif
 
 #if defined(__powerpc64__) && defined(_ARCH_PWR8)
 #define PPC64_HAS_VMX


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42555.131500.patch
Type: text/x-patch
Size: 503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180125/9d4645d3/attachment-0001.bin>


More information about the cfe-commits mailing list