[PATCH] D42480: [clangd] Provide a helper to report estimated memory usage per-file

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 25 06:28:59 PST 2018


ilya-biryukov added a comment.

Thanks for reviewing this!



================
Comment at: unittests/clangd/ClangdTests.cpp:428
 
+TEST_F(ClangdVFSTest, MemoryUsage) {
+  MockFSProvider FS;
----------------
ioeric wrote:
> ilya-biryukov wrote:
> > ioeric wrote:
> > > Can we add a test for non-empty files and check that the usage is reasonable (e.g. `>0`)?
> > We do exactly that. 
> My bad! 
> ```
> struct Something {
>   int method();
> };
> ```
> looks like real code on phabricator!
Phabricator is too smart :-)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42480





More information about the cfe-commits mailing list