[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 25 02:29:54 PST 2018


xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.

Overall looks good! Thanks for working on this!



================
Comment at: lib/AST/ExternalASTMerger.cpp:403
+    ASTImporter *Importer = C.second;
+    NamedDecl *ND = cast<NamedDecl>(Importer->Import(LookupRes));
+    assert(ND);
----------------
Usually, we expect that `Import` calls might fail and return `nullptr`s. If this is special for some reason I think it worth a comment.


Repository:
  rC Clang

https://reviews.llvm.org/D42301





More information about the cfe-commits mailing list