[PATCH] D42466: [Sema] Allow disabling typo correction when doing code completion.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 24 06:41:02 PST 2018


ilya-biryukov added inline comments.


================
Comment at: lib/Sema/Sema.cpp:143
       ArgumentPackSubstitutionIndex(-1), CurrentInstantiationScope(nullptr),
-      DisableTypoCorrection(false), TyposCorrected(0), AnalysisWarnings(*this),
+      DisableTypoCorrection(
+          CodeCompleter ? CodeCompleter->disableTypoCorrection() : false),
----------------
It seems weird that typo-correction is only controlled by `CodeCompleter` for all of `Sema`.
I wonder whether putting that into `FrontendOptions` makes more sense. WDYT?


Repository:
  rC Clang

https://reviews.llvm.org/D42466





More information about the cfe-commits mailing list