[PATCH] D42419: [clangd] Use new URI with scheme support in place of the existing LSP URI

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: clangd/ClangdLSPServer.cpp:386
+  if (!U)
+    llvm_unreachable(
+        "onDiagnosticsReady: Expect creating URI for file to always work.");
----------------
not sure if this is the right thing to do. idea?


================
Comment at: clangd/URI.h:32
+  // By default, create a simplest valid file URI.
+  URI() : Scheme("file") {}
+
----------------
same here. There are many default constructions of structures that contain URIs in ClangdLSPServer.cpp...


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42419