[PATCH] D42019: [Driver] Set default sysroot for Fuchsia if none is specified

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 22 20:23:39 PST 2018


phosek added inline comments.


================
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:152
+  llvm::sys::path::append(P, normalizeTriple(Triple));
+  return P.str();
+}
----------------
mcgrathr wrote:
> The GCC behavior (if --with-sysroot is given to configure) is tooldir/sys-root, not tooldir itself.
That's fine with me, although I'm not very fond of the `sys-root` since it's typically spelled as `sysroot` everywhere else, but I could be convinced if we want to be consistent with GCC.


Repository:
  rC Clang

https://reviews.llvm.org/D42019





More information about the cfe-commits mailing list