[PATCH] D42036: [clang-format] Keep comments aligned to macros

Mark Zeren via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 22 16:14:36 PST 2018


mzeren-vmw added a comment.

In https://reviews.llvm.org/D42036#984401, @djasper wrote:

> To me, aligning with the define seems fundamentally wrong.


we definitely have code that does that internally. It can also be seen in the wild e.g.:
https://github.com/boostorg/config/blob/develop/include/boost/config/detail/posix_features.hpp
However, it seems reasonable that clang-format's "default" be alignment with #. That will be a simpler patch, and it will resolve the toggling behavior. Let me work that up in a separate review.


Repository:
  rC Clang

https://reviews.llvm.org/D42036





More information about the cfe-commits mailing list