[PATCH] D42242: Make libc++abi work with gcc's ARM unwind library
Benjamin Buch via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 22 00:57:04 PST 2018
bebuch added a comment.
Thanks for the amazing patch!
I get another error:
/home/pi/projects/llvm/llvm/projects/libcxxabi/src/cxa_default_handlers.cpp: In function ‘void demangling_terminate_handler()’:
/home/pi/projects/llvm/llvm/projects/libcxxabi/src/cxa_default_handlers.cpp:41:58: error: ISO C++ forbids comparison between pointer and integer [-fpermissive]
unwind_exception->exception_class == kOurDependentExceptionClass ?
^
The comparison is still between uint8_t[8] and uint64_t. Please add a fix for this, then I will test again. :-)
BTW: Is the memcpy a better choice than a reinterpret_cast?
https://reviews.llvm.org/D42242
More information about the cfe-commits
mailing list