[PATCH] D42344: [libc++] Use multi-key tree search for {map, set}::{count, equal_range}

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 21 09:27:04 PST 2018

mclow.lists added a comment.

In https://reviews.llvm.org/D42344#983265, @ng wrote:

> In https://reviews.llvm.org/D42344#983264, @mclow.lists wrote:
> > Shouldn't there be tests for `multimap` and `multiset`, too?
> Sure; will the same tests as for map/set be alright?

Actually, I think there are already tests for `multimap` and `multiset`.
(which is why I deleted my comment)

But the tests there are not like these, where the comparator uses only part of the key.
So, yes; same tests would be OK - but you might want to adjust the data so that there are duplicate keys.


More information about the cfe-commits mailing list