[PATCH] D42261: [clang-tidy objc-property-declaration] New option AdditionalAcronyms

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 19 01:35:57 PST 2018

hokein added inline comments.

Comment at: clang-tidy/objc/PropertyDeclarationCheck.h:38
     const std::vector<std::string> SpecialAcronyms;
+    const std::vector<std::string> AdditionalAcronyms;
nit: code indent

Comment at: docs/clang-tidy/checks/objc-property-declaration.rst:47
+.. option:: AdditionalAcronyms
It seems to me the `Acronyms` and `AdditionalAcronyms` play most same role here. 

If we want to keep the long default list, how about using a bool flag `IncludeDefaultList` + the existing `Acronyms` option?

* if `IncludeDefaultList` is on, the acronyms will be "default" + "Acronyms".
* if `IncludeDefaultList` is off, the acronyms will be only "Acronyms".

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list