[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

Steve O'Brien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 18 12:30:58 PST 2018

elsteveogrande marked 2 inline comments as done.
elsteveogrande added inline comments.

Comment at: tools/c-index-test/c-index-test.c:3268
-  filename = clang_getFileName(file);
-  index_data->main_filename = clang_getCString(filename);
-  clang_disposeString(filename);
+  index_data->main_filename = clang_getFileName(file);
elsteveogrande wrote:
> vsk wrote:
> > This looks like a separate bug fix. Is it possible to separate the main_filename changes from this patch?
> Will do!
Done: https://reviews.llvm.org/D42259

  rC Clang


More information about the cfe-commits mailing list