[PATCH] D41947: Provide default virtual filesystem argument to ClangTool constructor

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 18 09:39:53 PST 2018

ilya-biryukov added inline comments.

Comment at: include/clang/Tooling/Tooling.h:299
   /// clang modules.
+  /// \param BaseFS Base virtual filesystem used for OverlayFileSystem creation
   ClangTool(const CompilationDatabase &Compilations,
NIT: LLVM coding style requires full stop at the end of comments.
Could we also rephrase it to not mention the `OverlayFileSystem`, the important bit seems to be that we use it for all fs operations. Something like:
/// \param BaseFS VFS used for all underlying file accesses when running the tool.

  rC Clang


More information about the cfe-commits mailing list