[PATCH] D42073: [clangd] Query all visible scopes based on all visible using-namespace declarationsand containing namespace for global qualified code completion.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 18 08:09:37 PST 2018

ilya-biryukov added inline comments.

Comment at: clangd/CodeComplete.cpp:270
+  /// namespace scopes which are visible to the qualified-id completion token.
+  std::vector<std::string> Scopes;
sammccall wrote:
> Just to check, if the user types:
> "vec" --> None
> "::vec" --> {""}
> "std::vec" --> {"std"}
> "using namespace std; vec" --> None
> "using namespace std; ::vec" --> {"", "std"}
> is this right?
I think the idea was to have (I only highlight the differences):
"vec" --> {""}
"using namespace std; vec" --> {"", "std"}

@hokein , or am I getting it wrong?

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list