[PATCH] D42074: [clangd] Collect enum constants in SymbolCollector

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 18 08:05:28 PST 2018

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM. (See the comment about changing the comment, though)

Comment at: clangd/index/SymbolCollector.cpp:75
+  // Skip nameless declarations.
+  if (ND->getDeclName().isEmpty())
+    return true;
hokein wrote:
> ilya-biryukov wrote:
> > What are those declarations exactly?
> This would  ignore anonymous declarations, e.g. anonymous class/enum. See the unittest.
Thanks for clarifying. Maybe we could change the comment to say "anonymous" instead of "nameless"? This is what bit got me confused.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list