[PATCH] D41408: [analyzer] NFC: Fix nothrow operator new definition in a test.

Phabricator via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 17 16:05:59 PST 2018

This revision was automatically updated to reflect the committed changes.
Closed by commit rL322790: [analyzer] NFC: operator new: Fix new(nothrow) definition in tests. (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.

Changed prior to commit:




Index: cfe/trunk/test/Analysis/NewDelete-custom.cpp
--- cfe/trunk/test/Analysis/NewDelete-custom.cpp
+++ cfe/trunk/test/Analysis/NewDelete-custom.cpp
@@ -4,16 +4,16 @@
 // RUN: %clang_analyze_cc1 -analyzer-checker=core,cplusplus.NewDelete,cplusplus.NewDeleteLeaks,unix.Malloc -std=c++11 -analyzer-config c++-allocator-inlining=true -DLEAKS=1 -DALLOCATOR_INLINING=1 -fblocks -verify %s
 #include "Inputs/system-header-simulator-cxx.h"
-#if !LEAKS
 // expected-no-diagnostics
 void *allocator(std::size_t size);
 void *operator new[](std::size_t size) throw() { return allocator(size); }
 void *operator new(std::size_t size) throw() { return allocator(size); }
-void *operator new(std::size_t size, std::nothrow_t& nothrow) throw() { return allocator(size); }
+void *operator new(std::size_t size, const std::nothrow_t &nothrow) throw() { return allocator(size); }
 void *operator new(std::size_t, double d);
 class C {
@@ -59,16 +59,13 @@
 //----- Custom NoThrow placement operators
 void testOpNewNoThrow() {
-  void *p = operator new(0, std::nothrow);
+  void *p = operator new(0, std::nothrow); // call is inlined, no warn
-#if LEAKS
-// expected-warning at -2{{Potential leak of memory pointed to by 'p'}}
 void testNewExprNoThrow() {
   int *p = new(std::nothrow) int;
-#if LEAKS
 // expected-warning at -2{{Potential leak of memory pointed to by 'p'}}

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41408.130307.patch
Type: text/x-patch
Size: 1537 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180118/5cdcf1fa/attachment.bin>

More information about the cfe-commits mailing list