[PATCH] D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool.
Eric Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 17 10:10:38 PST 2018
ioeric added inline comments.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:109
+ // Deduplicate the result by key.
+ // FIXME(ioeric): we need a better way to merge symbols with the same key. For
+ // example, class forward-declarations can have the same key as the class
> nit: this comment could be tightened up a bit:
> // FIXME(ioeric): Merge occurrences, rather than just dropping all but one.
> // Definitions and forward declarations have the same key and may both have information.
> // Usage count will need to be aggregated across occurrences, too.
rCTE Clang Tools Extra
More information about the cfe-commits