[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 17 08:50:30 PST 2018

sammccall accepted this revision.
sammccall added a comment.

Thanks, LG!

Comment at: clangd/Compiler.h:39
+/// Returns null on errors. When non-null value is returned, it is expected to
+/// be consumed by FrontendAction::BeginSourceFile to properly destroy buffer
+/// for \p MainFile.
nit: "buffer for MainFile" -> "MainFile"
(since MainFile is already a buffer. also: less wrapping!)

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list