[PATCH] D42168: [OpenMP] Generate unique name for offloading entries

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 17 08:12:00 PST 2018

ABataev added a comment.

In https://reviews.llvm.org/D42168#978594, @Hahnfeld wrote:

> In https://reviews.llvm.org/D42168#978593, @ABataev wrote:
> > After some investigation, I think this whole code is incorrect. We should not rely on the fact that there is no padding on some architectures and should mix the type generated by the Clang and initial value, generated by LLVM.
> I'm not sure I understand what you mean. Do you refer to `auto Align = CharUnits::fromQuantity(1)`?

Yes, this one too. But the main problem here is that we expect some layout of structure, though it may be different.

  rC Clang


More information about the cfe-commits mailing list