[PATCH] D42181: [clangd] Merge index-provided completions with those from Sema.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 17 06:52:04 PST 2018

sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, mgrang, ilya-biryukov, klimek.

- we match on USR, and do a field-by-field merge if both have results
- scoring is post-merge, with both sets of information available (for now, sema priority is used if available, static score for index results)
- limit is applied to the complete result set (previously index ignored limit)
- CompletionItem is only produces for the returned results
- If the user doesn't type a scope, we send the scopeless query to the index for global completion.

This needs tests for the new functionality, but I thought you could take a look
while I work on that. It passes the existing tests, and works in VSCode.

  rCTE Clang Tools Extra



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42181.130173.patch
Type: text/x-patch
Size: 32602 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180117/e672e093/attachment-0001.bin>

More information about the cfe-commits mailing list