[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.
Alex Bradbury via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 17 06:02:06 PST 2018
asb added a comment.
In https://reviews.llvm.org/D41271#977222, @apazos wrote:
> I tested this on windows and I had to add an assembler placeholder executable, just like it was done with the linker in the RISCV multilib dir checked under Inputs.
> Other observations, are these known issues?
> - multilib dir checked in has only riscv64-unknown-linux-gnu which we see the riscv tests invoking even when the target is 32 bit.
> - riscv64 is not honoring gcc-toolchain flag, it keeps invoking default /usr/bin/as. Anyways, the test now passes on windows.
For the first issue: I've matched the multilib toolchain generated from the riscv-gnu-toolchain build scripts, which uses the riscv64-* triple prefix throughout (see https://github.com/riscv/riscv-gnu-toolchain/issues/296).
For the second: driver support for riscv64 hasn't been added, as we don't yet have codegen support upstream. Codegen support doesn't really block driver+tests of course, so we can add riscv64 if it's useful to you.
More information about the cfe-commits