[PATCH] D42092: implement C++ dr388 for the Itanium C++ ABI: proper handling of catching exceptions by reference

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 16 17:34:56 PST 2018

rnk added inline comments.

Comment at: lib/CodeGen/ItaniumCXXABI.cpp:3867
+    // subsequent catches in the same try statement to catch such a rethrow.
+    // See C++ DR 388.
+    if (!CanBindToTemporary && MaybeTypeMatch) {
Based on our conversation, this fix feels a bit heroic. I think it would be better to find a way to put the const-ness in the LSDA and let new versions of the EH runtime deal with this.

  rC Clang


More information about the cfe-commits mailing list