[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 15 09:07:37 PST 2018

JonasToth added inline comments.

Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.cpp:47
+                            "^::std::launder$|"
+                            "^::std::unique_ptr<.*>::release$|"
+                            "^::std::.*::allocate$|"
khuttun wrote:
> JonasToth wrote:
> > Is the following type a problem for you check?
> > 
> > `std::unique_ptr<std::vector<int>>` should not be matchable with regex but I don't know if that would have an impact on the functionality.
> `std::unique_ptr<std::vector<int>>` is also matched. I added a test case for it.
Alright. I think i had a error in my thinking. Because there are followup letters in the regex there are no problems. I thought it would end on the first `>`, but thats no the case! Thank you for clarification :)


More information about the cfe-commits mailing list