[PATCH] D42074: [clangd] Collect enum constants in SymbolCollector

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 15 08:55:31 PST 2018

ilya-biryukov added inline comments.

Comment at: clangd/index/SymbolCollector.cpp:75
+  // Skip nameless declarations.
+  if (ND->getDeclName().isEmpty())
+    return true;
What are those declarations exactly?

Comment at: unittests/clangd/SymbolCollectorTests.cpp:174
+    enum class Color2 {
+      Yellow
+    };
I'd say we should drop `enum` constants inside stongly-typed enums (i.e. `enum class`).
They can't be found inside namespace by code completion, therefore being similar to static method in that regard. (And we don't include static methods now, right?)

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list