[PATCH] D42059: [clangd] Improve const-correctness of Symbol->Detail. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 15 04:03:32 PST 2018

sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, ilya-biryukov, klimek.

This would have caught a bug I wrote in an early version of https://reviews.llvm.org/D42049, where
an index user could overwrite data internal to the index because the Symbol is
not deep-const.

The YAML traits are now a bit more verbose, but separate concerns a bit more
nicely: ArenaPtr can be reused for other similarly-allocated objects, including
scalars etc.

  rCTE Clang Tools Extra



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D42059.129830.patch
Type: text/x-patch
Size: 3514 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180115/5363ff2a/attachment.bin>

More information about the cfe-commits mailing list