[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

Brian Gesiak via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 14 09:54:00 PST 2018


modocache updated this revision to Diff 129785.
modocache added a comment.

Thanks for the great review, @GorNishanov! You were exactly right, I had to remove the assert. I've taken all of your other suggestions as well. Let me know if anything else stands out at you. Also, thanks for the question, @EricWF, I added some comments to make it clear that this is an implementation of an experimental feature that has yet to be formally proposed.


Repository:
  rC Clang

https://reviews.llvm.org/D41820

Files:
  include/clang/Sema/ScopeInfo.h
  include/clang/Sema/Sema.h
  lib/Sema/CoroutineStmtBuilder.h
  lib/Sema/ScopeInfo.cpp
  lib/Sema/SemaCoroutine.cpp
  lib/Sema/TreeTransform.h
  test/CodeGenCoroutines/coro-params.cpp
  test/SemaCXX/coroutines.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41820.129785.patch
Type: text/x-patch
Size: 16028 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180114/5661a0d8/attachment-0001.bin>


More information about the cfe-commits mailing list