[PATCH] D41963: [clang-tidy] Adding Fuchsia checker for thread local storage.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tidy/fuchsia/CMakeLists.txt:6
   FuchsiaTidyModule.cpp
+  ThreadLocalCheck.cpp
   OverloadedOperatorCheck.cpp
----------------
Please keep this list in alphabetical order.


================
Comment at: clang-tidy/fuchsia/ThreadLocalCheck.cpp:27
+  if (const auto *D = Result.Nodes.getNodeAs<VarDecl>("decl"))
+    diag(D->getLocStart(), "thread local storage is disallowed");
+}
----------------
The docs say it's only disallowed in kernel mode. Can you remind me again -- are the fuchsia checks *only* for kernel mode, or is that the "zircon" part? I'm wondering if this check is overly broad for the guidelines, basically.


https://reviews.llvm.org/D41963