[PATCH] D41668: [clangd] Add static index for the global code completion.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 10 06:16:16 PST 2018


sammccall added inline comments.


================
Comment at: clangd/CodeComplete.cpp:661
+  if (CompletedName.SSInfo) {
+    // For a namespace scope specifier ("ns::"), we have disabled Sema from
+    // collecting completion results by setting IncludeNamespaceLevelDecls to
----------------
I don't think we need this - we plan to avoid overlap by splitting on current file vs other files - i'll put together a patch to make sema do what we want.
Until we've got that done, having some duplicate results is OK (this feature is experimental still).


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D41668





More information about the cfe-commits mailing list