[PATCH] D41897: Fixing a crash in Sema.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added reviewers: rsmith, aaron.ballman.
aaron.ballman added inline comments.


================
Comment at: Sema/SemaDeclCXX.cpp:2426
+    // Skip all dependent types in templates being used as base specifiers.
+    // Checks below assume that base specifier is a CXXRecord.
+    if (BaseType->isDependentType()) {
----------------
that base -> that the base


================
Comment at: Sema/SemaDeclCXX.cpp:2427-2429
+    if (BaseType->isDependentType()) {
+      continue;
+    }
----------------
You can elide the braces here.


================
Comment at: SemaCXX/base-class-ambiguity-check.cpp:1
+// RUN: %clang_cc1 -fsyntax-only %s
+
----------------
This run line isn't testing anything. Since you're trying to ensure this doesn't crash, I would put `-verify` on the RUN line and `// expected-no-diagnostics` on the line below.


================
Comment at: SemaCXX/base-class-ambiguity-check.cpp:9
+
+        struct Derived : Base, T
+        { };
----------------
I would add a comment around here explaining that this used to crash.


================
Comment at: SemaCXX/base-class-ambiguity-check.cpp:12
+};
\ No newline at end of file

----------------
Can you add a newline at the end of the file, and then run the file through clang-format to properly format it?


https://reviews.llvm.org/D41897