[PATCH] D41266: [analyzer] With c++-allocator-inlining, fix memory space for operator new pointers.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 9 19:37:57 PST 2018


NoQ updated this revision to Diff 129213.
NoQ added a comment.

Rebase. Address the comment.

In https://reviews.llvm.org/D41266#959763, @NoQ wrote:

> Remove the redundant cast that is done in `c++-allocator-inlining` mode when modeling array new. After rebase it started causing two identical element regions top appear on top of each other.


Remove this workaround because i reverted the change for which it is a workaround in https://reviews.llvm.org/D41250#971888: we no longer add the redundant `ElementRegion`, so we don't need to defend from double `ElementRegion`s here. I guess it all finally starts to make sense.


https://reviews.llvm.org/D41266

Files:
  lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
  lib/StaticAnalyzer/Core/ExprEngineCallAndReturn.cpp
  test/Analysis/NewDelete-checker-test.cpp
  test/Analysis/new-ctor-null.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41266.129213.patch
Type: text/x-patch
Size: 4858 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180110/ec835917/attachment-0001.bin>


More information about the cfe-commits mailing list