[PATCH] D41816: [analyzer] Model and check unrepresentable left shifts

Reka Kovacs via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 9 06:18:04 PST 2018


rnkovacs added a comment.

In https://reviews.llvm.org/D41816#970845, @xazax.hun wrote:

> Overall looks good to me, one comment inline. I think it is good to have these checks to prevent the analyzer executing undefined behavior. Maybe this would make it more feasible to run the analyzer with ubsan :)
>  In the future, it would be great to also look for these cases symbolically, but I believe it is perfectly fine to have that in a separate patch.


I agree, but I thought that making these checks complete first might be a good idea.


https://reviews.llvm.org/D41816





More information about the cfe-commits mailing list