[PATCH] D41759: [clangd] Catch more symbols in SymbolCollector.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM (see the review comment about adding a comment in the code too)



================
Comment at: clangd/index/SymbolCollector.cpp:89
+    // violations.
+    if (ND->isInAnonymousNamespace())
       return true;
----------------
hokein wrote:
> ilya-biryukov wrote:
> > Why don't we include symbols from anonymous namespaces too?
> > They are very similar to static symbols.
> Yeah, these symbols need a special handling (the qualified name is like `foo::<anonymous>::bar`), we don't support them well enough. I think it is fine to ignore them at the moment.
Makes sense.
Let's add a comment on why we skip them here.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D41759