[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

Casey Carter via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 5 18:32:05 PST 2018


CaseyCarter added inline comments.


================
Comment at: test/std/numerics/numeric.ops/transform.exclusive.scan/transform_exclusive_scan_init_bop_uop.pass.cpp:33
+    template <typename T>
+    constexpr auto operator()(T x) const noexcept {
+        return static_cast<T>(x + 10);
----------------
Although it doesn't matter to these tests, this notably doesn't have return type SFINAE as @mclow.lists suggested in his comment. Marshall, do you care, and if so, why?


https://reviews.llvm.org/D41748





More information about the cfe-commits mailing list