[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 4 16:14:22 PST 2018

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Thanks, looks good other than `ExpressionType`. This is fine to commit with either of the names I suggested; let me know if you have a better alternative :)

Comment at: include/clang/Sema/Sema.h:935-939
+  /// \brief Describes whether we are in an expression that needs
+  /// special handling.
+  enum class ExpressionType {
+    Decltype, TemplateParameter, Other
+  };
This name is too vague as a member of Sema, but would be OK as a member of `ExpressionEvaluationContextRecord`, or if renamed to something like `ExpressionEvaluationContextExprKind`. (Also, we generally use `Kind` rather than `Type` for situations like this.)


More information about the cfe-commits mailing list