[PATCH] D41736: make attribute instantiation instantiate all attributes

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 4 15:26:06 PST 2018

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, thank you!

Comment at: include/clang/AST/Attr.h:142
+  /// explicitly provided in the current declaration?
+  bool isInheritEvenIfAlreadyPresent() const {
+    return InheritEvenIfAlreadyPresent;
rsmith wrote:
> aaron.ballman wrote:
> > I'm not too keen on the name -- perhaps `isInheritedEvenIfAlreadyPresent()`?
> I started with that, but then changed to this abomination because `isInherited[...]` suggests it's telling you whether this attribute was inherited (like `isInherited()` does), which is not what it's for.
> How about `shouldInheritEvenIfAlreadyPresent`?

  rC Clang


More information about the cfe-commits mailing list