[PATCH] D41736: make attribute instantiation instantiate all attributes

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 4 14:39:38 PST 2018

rsmith added a comment.

In https://reviews.llvm.org/D41736#967552, @aaron.ballman wrote:

> I don't suppose there is a chance at test coverage for this change?

Added Erich's test, plus a test that all instances of another attribute (`annotate`) get instantiated (the latter test failed prior to this change).

Comment at: include/clang/AST/Attr.h:142
+  /// explicitly provided in the current declaration?
+  bool isInheritEvenIfAlreadyPresent() const {
+    return InheritEvenIfAlreadyPresent;
aaron.ballman wrote:
> I'm not too keen on the name -- perhaps `isInheritedEvenIfAlreadyPresent()`?
I started with that, but then changed to this abomination because `isInherited[...]` suggests it's telling you whether this attribute was inherited (like `isInherited()` does), which is not what it's for.

How about `shouldInheritEvenIfAlreadyPresent`?

  rC Clang


More information about the cfe-commits mailing list