[PATCH] D41720: [clang-tidy] Add a -show-color flag.

Ian Tessier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 4 14:35:20 PST 2018

itessier marked an inline comment as done.
itessier added a comment.

> This patch is missing test coverage.


Comment at: clang-tidy/tool/ClangTidyMain.cpp:150-152
+Show color diagnostics. If not specified,
+defaults to on when a color-capable terminal
+is detected.)"),
aaron.ballman wrote:
> I think this raw string can be reflowed a bit?
> Instead of "defaults to on", how about "Defaults to true when a color-capable terminal is detected."?
I copied that part from the -fcolor-diagnostics flag to be consistent. I don't changing "on" to "true" if you prefer that instead.


More information about the cfe-commits mailing list