[PATCH] D41629: [libcxx] Improve accuracy of complex asinh and acosh

Mikhail Maltsev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 3 17:26:23 PST 2018

miyuki added inline comments.

Comment at: test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp:59
+        {
+            assert(r.real() == 0);
+            assert(!std::signbit(r.real()));
Ideally, I would prefer some approximate comparison instead of `==` here, but `is_about` is not suitable for arguments that have zero or near-zero sum. That's why I used exact comparison (several other cases in this file do the same). This test passes on x86_64, so hopefully it will work the same way in any IEEE-compliant environment.


More information about the cfe-commits mailing list