[PATCH] D41680: [analyzer] do not crash with assertion on processing locations of bodyfarmed functions
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 2 14:27:15 PST 2018
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yep, so it still doesn't answer if `removePiecesWithInvalidLocations()` was dead code to begin with (considering that the assertion in `adjustCallLocations()` says that everything but call locations is valid by now, and call locations are fixed immediately after that). The piece with invalid location seems to be a control flow piece (grey piece / arrow) which is indeed not to be displayed to the user in this case. I'm still not sure how/if-at-all this worked before. But the new behavior looks correct and i don't see these questions as the most pressing issues we're having at the moment :)
More information about the cfe-commits