[PATCH] D41677: Change memcpy/memove/memset to have dest and source alignment attributes.

[Daniel Neilson via Phabricator via cfe-commits]

dneilson created this revision.
dneilson added a reviewer: rjmccall.
Herald added subscribers: fedor.sergeev, kbarton, aheejin, sbc100, javed.absar, nhaehnle, nemanjai, jyknight.

Upstream LLVM is changing the the prototypes of the @llvm.memcpy/memmove/memset
intrinsics. This change updates the Clang CGBuilder and the Clang tests
for this change.

The @llvm.memcpy/memmove/memset intrinsics currently have an explicit argument
which is required to be a constant integer. It represents the alignment of the
dest (and source), and so must be the minimum of the actual alignment of the
two.

This change allows source and dest to each have their own alignments by
using the alignment attribute on their arguments. The alignment argument
is removed.

For example, code which used to read:
 call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 100, i32 4, i1 false)
will now read
 call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 4 %dest, i8* align 4 %src, i32 100, i1 false)


Repository:
  rC Clang

https://reviews.llvm.org/D41677

Files:
  lib/CodeGen/CGBuilder.h
  test/CodeGen/2007-11-07-CopyAggregateAlign.c
  test/CodeGen/2007-11-07-ZeroAggregateAlign.c
  test/CodeGen/64bit-swiftcall.c
  test/CodeGen/aarch64-neon-intrinsics.c
  test/CodeGen/aarch64-neon-ldst-one.c
  test/CodeGen/aarch64-neon-perm.c
  test/CodeGen/aarch64-poly64.c
  test/CodeGen/aarch64-v8.2a-neon-intrinsics.c
  test/CodeGen/arm-arguments.c
  test/CodeGen/arm64-be-bitfield.c
  test/CodeGen/arm_neon_intrinsics.c
  test/CodeGen/atomic-arm64.c
  test/CodeGen/block-byref-aggr.c
  test/CodeGen/builtin-memfns.c
  test/CodeGen/c11atomics-ios.c
  test/CodeGen/c11atomics.c
  test/CodeGen/compound-literal.c
  test/CodeGen/le32-vaarg.c
  test/CodeGen/ms-intrinsics.c
  test/CodeGen/no-opt-volatile-memcpy.c
  test/CodeGen/packed-nest-unpacked.c
  test/CodeGen/packed-structure.c
  test/CodeGen/partial-reinitialization2.c
  test/CodeGen/ppc-varargs-struct.c
  test/CodeGen/ppc64-align-struct.c
  test/CodeGen/ppc64-soft-float.c
  test/CodeGen/ppc64le-aggregates.c
  test/CodeGen/sparc-vaarg.c
  test/CodeGen/tbaa-struct.cpp
  test/CodeGen/volatile.c
  test/CodeGen/wasm-varargs.c
  test/CodeGen/windows-swiftcall.c
  test/CodeGen/x86-atomic-long_double.c
  test/CodeGen/x86_32-arguments-realign.c
  test/CodeGen/x86_64-arguments.c
  test/CodeGen/xcore-abi.c
  test/CodeGenCXX/alignment.cpp
  test/CodeGenCXX/assign-construct-memcpy.cpp
  test/CodeGenCXX/constructor-direct-call.cpp
  test/CodeGenCXX/copy-constructor-elim.cpp
  test/CodeGenCXX/copy-constructor-synthesis-2.cpp
  test/CodeGenCXX/copy-constructor-synthesis.cpp
  test/CodeGenCXX/cxx0x-delegating-ctors.cpp
  test/CodeGenCXX/cxx0x-initializer-array.cpp
  test/CodeGenCXX/cxx11-initializer-array-new.cpp
  test/CodeGenCXX/cxx1z-lambda-star-this.cpp
  test/CodeGenCXX/eh.cpp
  test/CodeGenCXX/float16-declarations.cpp
  test/CodeGenCXX/microsoft-abi-sret-and-byval.cpp
  test/CodeGenCXX/microsoft-abi-virtual-inheritance.cpp
  test/CodeGenCXX/microsoft-uuidof.cpp
  test/CodeGenCXX/new-array-init.cpp
  test/CodeGenCXX/no-opt-volatile-memcpy.cpp
  test/CodeGenCXX/pod-member-memcpys.cpp
  test/CodeGenCXX/pr20897.cpp
  test/CodeGenCXX/value-init.cpp
  test/CodeGenCXX/varargs.cpp
  test/CodeGenObjC/arc-foreach.m
  test/CodeGenObjC/arc.m
  test/CodeGenObjC/builtin-memfns.m
  test/CodeGenObjC/messages-2.m
  test/CodeGenObjC/stret-1.m
  test/CodeGenObjCXX/arc-exceptions.mm
  test/CodeGenOpenCL/amdgcn-automatic-variable.cl
  test/CodeGenOpenCL/amdgpu-nullptr.cl
  test/CodeGenOpenCL/partial_initializer.cl
  test/CodeGenOpenCL/private-array-initialization.cl
  test/Modules/templates.mm
  test/OpenMP/atomic_write_codegen.c
  test/OpenMP/distribute_firstprivate_codegen.cpp
  test/OpenMP/distribute_lastprivate_codegen.cpp
  test/OpenMP/distribute_parallel_for_firstprivate_codegen.cpp
  test/OpenMP/distribute_parallel_for_lastprivate_codegen.cpp
  test/OpenMP/distribute_parallel_for_simd_firstprivate_codegen.cpp
  test/OpenMP/distribute_parallel_for_simd_lastprivate_codegen.cpp
  test/OpenMP/distribute_simd_firstprivate_codegen.cpp
  test/OpenMP/distribute_simd_lastprivate_codegen.cpp
  test/OpenMP/for_firstprivate_codegen.cpp
  test/OpenMP/for_lastprivate_codegen.cpp
  test/OpenMP/for_reduction_codegen.cpp
  test/OpenMP/nvptx_target_firstprivate_codegen.cpp
  test/OpenMP/ordered_doacross_codegen.cpp
  test/OpenMP/parallel_codegen.cpp
  test/OpenMP/parallel_copyin_codegen.cpp
  test/OpenMP/parallel_firstprivate_codegen.cpp
  test/OpenMP/parallel_reduction_codegen.cpp
  test/OpenMP/sections_firstprivate_codegen.cpp
  test/OpenMP/sections_lastprivate_codegen.cpp
  test/OpenMP/sections_reduction_codegen.cpp
  test/OpenMP/single_codegen.cpp
  test/OpenMP/single_firstprivate_codegen.cpp
  test/OpenMP/target_enter_data_depend_codegen.cpp
  test/OpenMP/target_exit_data_depend_codegen.cpp
  test/OpenMP/target_firstprivate_codegen.cpp
  test/OpenMP/target_teams_distribute_firstprivate_codegen.cpp
  test/OpenMP/target_teams_distribute_lastprivate_codegen.cpp
  test/OpenMP/target_teams_distribute_simd_firstprivate_codegen.cpp
  test/OpenMP/target_teams_distribute_simd_lastprivate_codegen.cpp
  test/OpenMP/target_update_depend_codegen.cpp
  test/OpenMP/task_codegen.cpp
  test/OpenMP/task_firstprivate_codegen.cpp
  test/OpenMP/taskgroup_task_reduction_codegen.cpp
  test/OpenMP/taskloop_firstprivate_codegen.cpp
  test/OpenMP/taskloop_lastprivate_codegen.cpp
  test/OpenMP/taskloop_reduction_codegen.cpp
  test/OpenMP/taskloop_simd_firstprivate_codegen.cpp
  test/OpenMP/taskloop_simd_lastprivate_codegen.cpp
  test/OpenMP/taskloop_simd_reduction_codegen.cpp
  test/OpenMP/teams_distribute_firstprivate_codegen.cpp
  test/OpenMP/teams_distribute_lastprivate_codegen.cpp
  test/OpenMP/teams_distribute_parallel_for_firstprivate_codegen.cpp
  test/OpenMP/teams_distribute_parallel_for_lastprivate_codegen.cpp
  test/OpenMP/teams_distribute_parallel_for_simd_firstprivate_codegen.cpp
  test/OpenMP/teams_distribute_parallel_for_simd_lastprivate_codegen.cpp
  test/OpenMP/teams_distribute_simd_firstprivate_codegen.cpp
  test/OpenMP/teams_distribute_simd_lastprivate_codegen.cpp
  test/OpenMP/teams_firstprivate_codegen.cpp