[PATCH] D41495: [clangd] Skip function bodies when building the preamble

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 2 01:46:32 PST 2018

ilya-biryukov added a comment.

In https://reviews.llvm.org/D41495#965627, @nik wrote:

> Hmm, could libclang profit from something like this, too? (or does it already?)

It could. The problem with ASTUnit is that it returns all diagnostics from `store_diag_begin`/`end`, not just the ones from the current file.
Skipping function bodies would mean no diagnostics from the preamble. Which may or may not be fine, I'm not sure how important those diagnostics are for the clients.



More information about the cfe-commits mailing list