[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 1 05:12:46 PST 2018

JonasToth added a comment.

I think it would be more user friendly if the configured list can be a list and the `|` concatenation is done within your code.

Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.cpp:29
+  llvm::raw_svector_ostream OS(InlinedName);
+  auto Policy = Node.getASTContext().getPrintingPolicy();
+  Policy.SuppressUnwrittenScope = true;
Don't use auto here, because the type is not written somewhere

Comment at: clang-tidy/bugprone/UnusedReturnValueCheck.cpp:53
+  // Detect unused return values by finding CallExprs with CompoundStmt parent,
+  // ignoring any implicit nodes and parentheses in between
+  Finder->addMatcher(
Missing full stop.


More information about the cfe-commits mailing list