[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 1 05:01:08 PST 2018

Eugene.Zelenko added inline comments.

Comment at: clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:13
+#include "clang/Lex/PPCallbacks.h"
+namespace clang {
Please include string and STLExtras.h.

Comment at: docs/clang-tidy/checks/cppcoreguidelines-macro-usage.rst:8
+constructs exist for the task.
Will be good idea to add link to relevant section in documentation.

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list