[PATCH] D41594: Support `ivfsoverlay` option in Tooling

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 28 02:07:46 PST 2017

ilya-biryukov added a comment.

I'm not sure if it's ok to ignore the shared `FileManager` here.
@klimek, @bkramer, @alexfh, does tooling library rely on having the same `FileManager` for all invocations? Is it just a performance optimization or there's more to it?

Comment at: lib/Tooling/Tooling.cpp:287
+  if (Files->getVirtualFileSystem() != VirtualFileSystem) {
+    Files = new FileManager(Invocation->getFileSystemOpts(), VirtualFileSystem);
+  }
`Files` is a raw pointer, so we're leaking memory here.

  rC Clang


More information about the cfe-commits mailing list