[PATCH] D41583: [x86][icelake][vaes]

[coby via Phabricator via cfe-commits]

coby added inline comments.


================
Comment at: lib/Basic/Targets/X86.cpp:573
     setMMXLevel(Features, AMD3DNowAthlon, Enabled);
   } else if (Name == "aes") {
     if (Enabled)
----------------
craig.topper wrote:
> Shouldn't -aes imply -vaes?
how come? perhaps i'm missing here something?
why would the first imply the latter?
following this road an atom z8XXX should be capable of supporting vaes, for example (where it lacks avx, for example, https://www.intel.com/content/www/us/en/processors/atom/atom-z8000-datasheet-vol-1.html)
also, in that sense, pclmul is implying vpclmulqdq


Repository:
  rC Clang

https://reviews.llvm.org/D41583